Brian Anderson

Results 400 comments of Brian Anderson

There's a thread open on irlo about the RFCs repo https://internals.rust-lang.org/t/relicense-the-rfcs-repo-under-the-cc-by-4-0-license/3870/3

I do intend to write a patch to fix this specific issue, which will improve reproducibility when built from different configurations of the same host platform. It won't result in...

One thing to note here is that this affects the builtin `file!` macro, so if some dependency is doing something funky with that macro it could break in unexpected ways.

One thing to note here is that this affects the builtin file! macro, so if some dependency is doing something funky with that macro it could break in unexpected ways.

> > is that this affects the builtin file! macro > > Do you have any examples of how use of a file! macro would be affected? Am I correct...

@leighmcculloch I have pushed a commit that does the remapping with `CARGO_BUILD_RUSTFLAGS` instead of `CARGO_ENCODED_RUSTFLAGS`. It has tradeoffs: One nice advantage is that `CARGO_BUILD_RUSTFLAGS` does get merged by cargo with...

> Can the value be escaped? I do not believe so. I looked but could not find evidence that this is unescaped anywhere.

> I'm thinking if we have a small test vector contract, and check that soroban contract build produces a valid wasm file, and then have some tests that run on...

I fixed the merge conflicts and manually retested. Building after the merge did change the lockfile significantly - I didn't look closely and assume it's correct.

> Extracting that metadata is definitely possible While this is possible, I believe these paths end of in a big blob of an rodata section, so parsing them out of...