Brian Anderson
Brian Anderson
Thanks for the report. My reasoning for deleting .cargo is that rustup is responsible for the installation of the entire rust 'world', including cargo, so when it uninstalls itself (and...
Thanks for the further feedback @ollie27. I agree the uninstall message could be more clear and give options to not delete the cargo directory. For now though my inclination is...
@Diggsey rustup will refuse to install over certain other rust installations, which might prevent some of the problem, but there's still no way to preserve `.cargo` during uninstall.
I'm excited for the improvements here. I've only just skimmed the code, and intend to review in depth this week. I have tested this a little on windows and the...
@wpaulino this is a great foundation for adding more advanced repl behavior. Very neat. I have done some more reading of the code and more testing on both Linux and...
Not sure if you are looking for more review here yet @wpaulino, but it seemed like I should circle back here in case you are wanting more feedback. I see...
> Thanks @brson, I am looking for more feedback/review :) > > All the issues you mentioned should be addressed now. I confirmed in all three OSs, including cygwin and...
Ok, I retested this in several environments and they all work consistently now: - Linux (WSL) in the Windows 11 Terminal, - Windows Command Prompt in the Windows 11 Termal,...
I pushed a merge commit to resolve the conflict here.
After some internal discussion, I understand we need to not introduce any new dynamic allocation to the repl (we can allocate during init, but not during execution - that's tigerstyle),...