Brian Anderson

Results 400 comments of Brian Anderson

@breeswish can you say more about "type-safe labels (in length)" or link to an issue explaining it?

Thanks @breeswish. cc @overvenus Getting fail and prometheus 1.0 out is not explicitly a Q1 goal for me, so others probably need to help, particularly with prometheus, which I sense...

Per my comments [here](https://github.com/pingcap/rust-prometheus/pull/216#issuecomment-458759614) I would like to make sure that the APIs for the crate both with and without protobufs has some kind of consistency before 1.0. As that...

I've unassigned myself as I don't see myself personally doing this work.

Hi @erikdesjardins. Thanks for this patch. I'll ping someone who can review.

@erikdesjardins are you depending on this code path, or just submitting this as cleanup?

> Where are the `ScError` transitions happening? I want to spend some more time debugging. I have looked at the code that is intended to propagate errors, see that it...

Changing the TestContractFrame's panic slot to hold a `HostError` instead of an `Error` is sufficient to recover the backtrace after a panic and continue propagating it. Here's a wip patch...

> Where are the `ScError` transitions happening? It wasn't actually literally converting to `ScError`, but rather `Error` - `escalate_error_to_panic` stuffs the `Error` from `HostError` into the frame, discards the original...

I've done a little more work on this here: https://github.com/brson/rs-soroban-env/tree/backtraces2 I've found 3 cases where a secondary error event discards the backtrace from the initial error event. One of them...