strum 0.25

Open kayabaNerve opened this issue 2 years ago • 2 comments

This does duplicate the syn dependency, unfortunately (v1 and v2). While there may accordingly be a desired to not merge this, as syn is presumably a heavier depend than strum, the only way the ecosystem will move forward is if eventually people move to syn v2.

Nov 28 '23 07:11 kayabaNerve

It looks like this fails the build on our minimum Rust version 1.48:

https://github.com/brson/wasm-opt-rs/actions/runs/7015422941/job/19305682921?pr=162

Seems that syn 2.0 doesn't support such an old compiler.

Dec 04 '23 22:12 brson

Thanks for the context. That's unfortunate.

While I'm fine closing this, mind if I ask why a version of 1.48 was chosen and considerations you'd make when discussing increasing it?

Dec 05 '23 00:12 kayabaNerve