brosssh

Results 62 comments of brosssh

> Actually, @anddea had already added a similar patch to his RVX fork. [anddea/revanced-patches@dfd7461](https://github.com/anddea/revanced-patches/commit/dfd7461ad6e0b93ffa5b3cfb8181c12c5a35e8a2) This might be helpful. > > Your patch is cleaner in the patches side, but about...

> > it's simply returning everything before ?si= > > That's true, I hadn't considered that aspect. But I've never come across links like that. Do you have any examples?...

I'm also just an amateur coder so please forgive me if my code is not optimal

@Ushie I checked but `verticalArrangement` is not adding the padding. I believe that is used to space items in a `Column` component, while I need to add it to the...

@Ushie Again, `verticalArrangement` is not adding the padding (unless I'm missing something) ![image0](https://github.com/user-attachments/assets/451c250a-4675-46be-a393-429e1260806c) ![image](https://github.com/user-attachments/assets/37b18401-c465-4055-8b26-182cd5d4501f). For the patches screen, `contentPadding` is not a valid parameter for a `Column` attribute, that only...

From a user which has no understanding on the dev process, I think reset patch selections/options description should be clarified. Personally, I don't understand what pressing that button will do...

Currently the page looks like this: https://github.com/ReVanced/revanced-manager/issues/2497#issuecomment-2881165638

Still up to discussing how the page should look, currently it's like this. ![Screenshot_2025-05-18-17-23-49-13_761fe8f2c59677c7476dd46708cfb34f.jpg](https://github.com/user-attachments/assets/cb89e7d9-565c-432a-b7e9-db71c5b76381) ![Screenshot_2025-05-18-17-23-55-59_761fe8f2c59677c7476dd46708cfb34f.jpg](https://github.com/user-attachments/assets/aa462a6c-b9d5-4160-b1ec-2b93b09f1585)

I didn't received much feedbacks, I've made the icon white/black (based on theme) and not grey, and also used the bundle name as the page title.