revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

fix: Patch selection screen padding

Open brosssh opened this issue 8 months ago • 3 comments

Closes https://github.com/ReVanced/revanced-manager/issues/2520 and also https://github.com/ReVanced/revanced-manager/issues/2502

Enough? Too much? Screenshot_2025-05-08-10-25-45-49_761fe8f2c59677c7476dd46708cfb34f

image0

brosssh avatar May 08 '25 08:05 brosssh

Can the padding be made more consistent with other screens?

I believe I use verticalArrangement for Columns across the app, that can be used for the dialog padding

As for the patches page padding, I don't exactly remember what it's called but I don't think I outright add padding, I think it might be called innerPadding in lazycolumns or something, also, why is there a lack of padding to begin with? there's supposed to be a default amount of padding, that should be looked into

Ushie avatar May 09 '25 09:05 Ushie

@Ushie I checked but verticalArrangement is not adding the padding. I believe that is used to space items in a Column component, while I need to add it to the top of the component..

brosssh avatar Jun 03 '25 18:06 brosssh

The verticalArrangement thing is for the add bundle dialog

contentPadding is for the patches screen, I'm not sure if contentPadding will work for landscape but it's worth a try

Ushie avatar Jun 03 '25 18:06 Ushie

@Ushie Again, verticalArrangement is not adding the padding (unless I'm missing something)

image0

image.

For the patches screen, contentPadding is not a valid parameter for a Column attribute, that only exists for LazyColumn.

brosssh avatar Jul 01 '25 12:07 brosssh