Results 667 comments of Brian Smith

I am expecting to do a new release on or before 2021-12-14.

> gcc (GCC) 8.3.0 Are you sure you're using gcc 8.3.0? I think your build environment might be picking up the default, ancient C compiler. Try using TARGET_CC or similar.

What is the exact command line you are using to build your crate, including the environment variables like TARGET_CC and the like?

Closing this as a duplicate of #1419. See that issue.

> `const PRIVATE_KEY_PUBLIC_MODULUS_MAX_BITS: bits::BitLength = bits::BitLength::from_usize_bits(4096)` > This const now is 4096. But this size is not enough for my project, now I just hard code as 8192. Can we...

I will revisit this after PR #1185 is merged. That should make it easier to implement, review, and test this.

@oconnor663 Are you still interested in this? Here's my suggested approach to this: 1. Implement `LessSafeKey::open_within_separate_tag`. 2. Re-implement `LessSafeKey::open_within` in terms of `LessSafeKey::open_within_separate_tag`. 3. Add tests to aead_tests.rs for the...

More discussion in https://github.com/briansmith/ring/pull/935

@aig787's PR #1067 added the -musl targets for Linux x86_64 and i686 to CI/CD. Still to do: - [ ] https://github.com/rust-lang/rust/pull/70740/ indicates that we need to verify that we're doing...

- [ ] https://github.com/alexcrichton/cc-rs/issues/436 indicates that we should be doing more sanity checks to make sure we're not using the wrong header files. e.g. statically asserting that `sizeof(uint64_t) == 8`....