Results 667 comments of Brian Smith

PR #1466 is the first step towards fixing this by improving the testing scaffolding.

First, thanks for reporting this. I think I have a fix already in my local tree. I have some questions though. > Furthermore, together with #1299 You filed #1299, and...

As a first step, I've refactored the Ed25519 PKCS#8 parser tests to get better coverage, which will enable the fixing of this. Those changes are in https://github.com/briansmith/ring/pull/1466.

@MikaelUrankar Thanks for the PR. I noticed that this looks almost exactly like the Linux version. Would it be possible to refactor this so that the Linux and FreeBSD version...

> Are the maintainers open to a PR for adding partial support for the latest draft (HPKE-12)? An implementation of base mode and support for at least one cipher suite...

> Thanks @briansmith, I'll ping you when I have some time to start work on this. Is [[email protected]](mailto:[email protected]) a good email address (from your GH profile) Great! Yes, that's the...

OK, I see the problem. I was mistaken about `bn_mul_mont`. It turns out that I didn't implement a fallback for `bn_mul_mont` in the way I expected. I had implemented a...

Note that in order for the MIPS assembly to work, we'd need to also bring in the MIPS perlasm translator, and then also patch it with whatever patches would be...

> Does it mean to keep `gfp_p256.c` and `gfp_p384.c` as part of the build for the big 4 or fully replace it for all platforms? 1. Delete the code for...