Results 661 comments of Brian Smith

> Hi @briansmith. Unfortunately I will not have any time soon to wrap it up. The notes you gave are good, and if I get time to revisit in the...

It's coming soon. ECDSA code is already written. X25519 and P-256/P-384 ECDH will follow shortly.

Hi, are you sure? Usually `as` is the assembler and `ar` is the archiver (library manager) and usually both exist.

When mk/cargo.sh does `"${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager" ndk-bundle`, it seems to be installing NDK 22 based on the log https://github.com/briansmith/ring/runs/1991696699?check_suite_focus=true: "Downloading android-ndk-r22-linux". I would be happy if you or somebody could update mk/install-build-tools.sh...

I'm going to close this for now since I see that NDK 23 is still in beta. Once it has a final release we can explore how to deal with...

> @briansmith now NDK23 has entered LTS I think it is unlikely that NDK 23 is missing the `-ar` executable. Maybe we need to invoke it differently. I think we...

@irediaes Thanks for that info. That sounds great. In *ring*'s CI/CD, `mk/cargo.sh` has this: ``` aarch64-linux-android) export CC_aarch64_linux_android=$android_tools/aarch64-linux-android21-clang export AR_aarch64_linux_android=$android_tools/aarch64-linux-android-ar export CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER=$android_tools/aarch64-linux-android21-clang ;; ``` and this: ``` armv7-linux-androideabi) export CC_armv7_linux_androideabi=$android_tools/armv7a-linux-androideabi18-clang...

I reopened this issue to track the need to update the documentation (`mk/cargo.sh` presently) and CI/CD to use the latest NDK.

As you've probably guessed, the traits are public but I didn't intend to make the trait methods publicly callable. That's just a mistake that I was making early on in...