Brett McBride

Results 292 comments of Brett McBride

> How do you run multiple samplers for a single `TracerProvider`? Samplers can already be composed in various ways - eg a `parentbased_always_on` sampler is actually a parent-based sampler and...

This is very interesting to me, when thinking about PHP's auto-instrumentation. When developing auto-instrumentation implementations, we currently lack the mechanism to optionally create spans for certain methods which are possibly...

I found another use-case that could fit in here.... Using auto-instrumentation to create spans for some low-level i/o functions (eg writing to a file/stream), can have a side-effect of creating...

@adriangb span attribute are [already available](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.27.0/specification/trace/sdk.md#sampler) for making sampling decisions (and the spec mentions that span attributes should be set early so that they are available to custom samplers). I...

@DrLuke sorry I'd missed this issue. You might also like to ask this on our slack channel where it might get more eyes on it.

> Should HttpKernel::handle() span names contain the controller as well? Not if they're treated like other requests, since the spec tells us how root spans should be named. It's quite...

@dkarlovi @DrLuke Can you please review the linked PR for this? I don't have a symfony app to test this against, but it looks like you do. I added tests...

@DrLuke @dkarlovi I've just released a new beta of the symfony auto-instrumentation. If you're happy with it, report back as I plan to release `1.0.0` if there are no other...

> do you think we have something to add to the Metrics section of the PHP service in the docs? Yes, I've just submitted a PR to add some manual...

Hello! OpenTelemetry for PHP is now deep into beta, and getting close to GA. We've just released an initial version of an [Opentracing-compatible shim on packagist](https://packagist.org/packages/open-telemetry/opentracing-shim) and would appreciate some...