opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

[OTel Demo] - Quote Service Metrics

Open julianocosta89 opened this issue 1 year ago • 7 comments

This OTel Demo PR added metrics to the PHP service. We need to add the process to the docs.

julianocosta89 avatar May 08 '23 09:05 julianocosta89

thanks for raising this @julianocosta89 !

svrnm avatar May 10 '23 15:05 svrnm

@open-telemetry/demo-approvers @open-telemetry/php-approvers is this still relevant?

svrnm avatar Oct 18 '23 13:10 svrnm

Yes, we need to update this section: https://opentelemetry.io/docs/demo/services/quote/#metrics

I can take care of this

julianocosta89 avatar Oct 18 '23 13:10 julianocosta89

thanks @julianocosta89

svrnm avatar Oct 18 '23 13:10 svrnm

if this issue is still active, please assign this issue to me, thanks

kennykguo avatar Feb 19 '24 01:02 kennykguo

hey @kennykguo, Please note that we are not assigning issues, as per our contribution guidelines, if you are interested to work on this issue let us know, and we keep track and wait for a PR from you. I recommend that you pick 1 or 2 issues you fill confident to provide a PR for within ~2 weeks.

svrnm avatar Feb 20 '24 08:02 svrnm

@kennykguo feel free to take it, I've actually forgot to update it. I was wrapping my head around it, as there is not much on metrics in the quoteservice other than those lines: https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/quoteservice/public/index.php#L64-L68

I'm not sure how we could add that in the docs, but I'm open to suggestions.

julianocosta89 avatar Feb 20 '24 12:02 julianocosta89

@brettmc do you think we have something to add to the Metrics section of the PHP service in the docs?

Otherwise I'll just close this issue

julianocosta89 avatar Apr 10 '24 13:04 julianocosta89

do you think we have something to add to the Metrics section of the PHP service in the docs?

Yes, I've just submitted a PR to add some manual metrics to quote service (there are some auto-generated ones there already), then I'll update the Metrics and Logs sections of the docs.

brettmc avatar Apr 11 '24 00:04 brettmc