opentelemetry.io
opentelemetry.io copied to clipboard
[OTel Demo] - Quote Service Metrics
This OTel Demo PR added metrics to the PHP service. We need to add the process to the docs.
thanks for raising this @julianocosta89 !
@open-telemetry/demo-approvers @open-telemetry/php-approvers is this still relevant?
Yes, we need to update this section: https://opentelemetry.io/docs/demo/services/quote/#metrics
I can take care of this
thanks @julianocosta89
if this issue is still active, please assign this issue to me, thanks
hey @kennykguo, Please note that we are not assigning issues, as per our contribution guidelines, if you are interested to work on this issue let us know, and we keep track and wait for a PR from you. I recommend that you pick 1 or 2 issues you fill confident to provide a PR for within ~2 weeks.
@kennykguo feel free to take it, I've actually forgot to update it.
I was wrapping my head around it, as there is not much on metrics in the quoteservice
other than those lines:
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/quoteservice/public/index.php#L64-L68
I'm not sure how we could add that in the docs, but I'm open to suggestions.
@brettmc do you think we have something to add to the Metrics section of the PHP service in the docs?
Otherwise I'll just close this issue
do you think we have something to add to the Metrics section of the PHP service in the docs?
Yes, I've just submitted a PR to add some manual metrics to quote service (there are some auto-generated ones there already), then I'll update the Metrics and Logs sections of the docs.