Brett McBride
Brett McBride
> would you be willing to work with JB to expand/rename this license to general OpenTelemetry Submitted a request to rename existing license and expand to x10 seats
> have we received the licenses already? We have not. No emails from jetbrains, and the license itself is unchanged. Thanks for the reminder, I've submitted another request 🤞
@open-telemetry/php-approvers I've addressed review comments, ready for re-review please
> Java Instrumentation has this concept PHP will likely follow Java's lead here. "local root span" I think resolves any ambiguity w.r.t distributed traces and remote parents, and returning an...
[PHP's implementation](https://github.com/open-telemetry/opentelemetry-php/pull/1310) is heavily influenced by [Java's implementation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/LocalRootSpan.java) We've taken the approach that when a span is activated, we check if its parent is remote or invalid. If yes, then...
I think it's ok to change to snake case, if you want to create a PR for it
Just taking a look over doctrine auto-instrumentation, since I'm kicking the tires for my day job. There isn't span linking, but that's the right way to do it. If NewRelic...
@Ardenexal these changes are in v0.3.0 - could you test it out and report back?
I might be missing something, but doctrine auto-instrumentation doesn't hook any method named `execute` that I can see. Which instrumentation packages do you have installed?
Sorry my mistake, my fork was not up-to-date. You're absolutely correct, and a PR to fix is submitted.