Brett McBride

Results 292 comments of Brett McBride

hi @amber0612 do you still want this one?

ok with me. I do agree that `makeCurrent` is not an intuitive method name, I personally prefer keeping `activate` FWIW.

As well as a PropagatorFactory, I think maybe we also need a singleton class which holds a collection of propagators (a bit like `MultiSpanProcessor`). and that's the class we'd interact...

Discussed in SIG today, agreed that initial implementation should be in API (since the spec requires that propagators work with an API-only installation)

@kishannsangani the spec also requires a [composite propagator](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#composite-propagator) - do you think that could be part of this issue, or separate?

@trivikr - the table looks pretty close to me I think we can call traces status "alpha" now). Did you want this assigned to you?

> do we have any extension packages in opentelemetry-php? discussed in SIG, please go ahead and create an extensions dir (this is what otel-java does)

I think `src/Extension/Propagator/B3` or something similar...

Welcome @Shubhamlmp and thanks for your contribution. We need you to sign the CLA before your contribution can be accepted.