Brett McBride

Results 292 comments of Brett McBride

Hi @lindsaygrace It took us a long time, but OpenTelemetry for PHP has today tagged 1.0.0 I hope you will consider marking this repo as deprecated and suggesting users towards...

OpenTelemetry for PHP has just reached 1.0.0 GA milestone. Please consider using it, and note that we have an [OpenTracing shim](https://packagist.org/packages/open-telemetry/opentracing-shim) to help users migrate across.

@dgafka the OpenTelemetry API, SDK, etc are officially released now: https://packagist.org/packages/open-telemetry Our next focus is to get the extension and some contrib packages also to 1.0.0 status.

I have not tried this before, but looking at the code for the `initialize_fiber_handler.php` file, it looks like you need to enable fiber support with `OTEL_PHP_FIBERS_ENABLED` - have you done...

I think we need some documentation and examples for context + async/fibers in https://opentelemetry.io/docs/instrumentation/php/

Somewhat related to this issue, I started writing some doco for Context in https://github.com/open-telemetry/opentelemetry.io/pull/3857 I touched on async context, but I think most of what is mentioned in this issue...

It looks like no other SIG has implemented this yet: https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md#opentracing-compatibility so, my vote is to drop this as a requirement for a GA release.

The `timeout` param is there because the spec says it should be: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.24.0/specification/performance.md#shutdown-and-explicit-flushing-could-block And, it doesn't work because we code to the PSR http client/request interfaces, and I believe there...

Today, that scenario won't work, and you'd need to instantiate a PsrTransport directly rather than use the factory. With guzzle and symfony's client, it's an option in the Client constructor....

> that could theoretically be improved, no Yes. It could use ::discover only if a client was not provided already.