Brage Sekse Aarset
Brage Sekse Aarset
> it's possible to add a boolean parameter and switch between old and new behaviour. My intent was just to resolve the issue faced in #2028 I think that is...
> I agree that we want the default to be false, but I think we can go forward with this PR with `strict = true` and add a TODO that...
> @braaar I don't think the default param option would really work [fiddle](https://jsfiddle.net/3u24tb7y/1/) You're right. We should probably do it [like this](https://jsfiddle.net/4cuxw8hd/3/)
You should change the PR title to ```feat(isRgbColor): add `strict` option to allow/disallow spaces between color values```
Honestly, maybe we should change the option name to `allowSpaces` instead of `strict`?
> @braaar is there a specific review process we need to go through ? You're gonna need an approval from a maintaner. As you can see, there is a bit...
Hello! Feel free to submit a pull request fixing this typo
Yeah, you're totally right, actually, @carkod, this issue does not belong in this project.
If @denishm116 could close it, it would save us from bothering the maintainers, I suppose.
No, I don't think so. We just have to wait for maintainer review.