Benjamin Pasero
Benjamin Pasero
> It seems required to set option `module` to `NodeNext.` But if we set `"module": "NodeNext"` the tsc will generate `export {}` at the end of the file in `preload.js`...
Would be great if this could move along 👍
Also https://github.com/Microsoft/vscode/issues/35572#issuecomment-339282965
@grothkopp this is only an issue if your query happens to fully match on the file name. once your query has enough significant characters from the parent folders it should...
@grothkopp yes good point, if you include a path separator, the matching on the file name alone will no longer happen.
Yes, https://github.com/microsoft/vscode/issues/25925#issuecomment-357261679 should be covered with https://github.com/microsoft/vscode/issues/30404
This is a good example, thanks for sharing. In both cases our algorithm prefers a better performing match in the file name over a match in the full path and...
@mrmachine a way to force VS Code into matching on the entire path is to separate segments with `/`, i.e. in your case can you try `url/def`?
@deepak1556 do we need to act on this breaking change for custom protocol handlers: https://www.electronjs.org/docs/latest/breaking-changes#behavior-changed-custom-protocol-url-handling-on-windows ?
This makes good sense to me 🎩