Benjamin Pasero

Results 424 comments of Benjamin Pasero

Seeing how it was working in `2.1.0`, I noticed a second mutex that was only used for `triggerCallbacks` and restoring that seems to fix the deadlock in `2.4.x` 🤞 PR:...

I updated https://github.com/parcel-bundler/watcher/pull/189 and now have more understanding when exactly this issue happens. The fix is relatively simple.

@aiday-mar I am having a hard time to follow. You indicate: > Lines where to add a callback and remove the 100ms timeout > ... > test/automation/src/editors.ts [line 15 to...

Reading this now for the third time, I think the ask is to get rid of the callback if its not needed and only have it otherwise for the tests...

✋ I would suggest to put this on hold, pending the outcome of https://github.com/microsoft/vscode/issues/246731

Yeah, specifically when executing a command, cancellation errros are now ignored.

@devongovett 👋 yeah, would be great to see a new version with the fix included

@devongovett 👋 curious if you could comment on this issue. So far, in VS Code we have actively prevented file system watchers from overlapping, i.e. no watcher was ever watching...

**Easy repro:** * open a markdown file with long lines so that you see word wrapping * reload the window * 🐛 word wrap is not applied @sandy081 need your...

> Before ESM, at that instance configurations of all extensions are read and registered and after ESM, they are not @sandy081 is there a way to drill into why that...