chore: update to Electron 34

[deepak1556]

Fixes https://github.com/microsoft/vscode/issues/237437

[bpasero]

@deepak1556 do we need to act on this breaking change for custom protocol handlers: https://www.electronjs.org/docs/latest/breaking-changes#behavior-changed-custom-protocol-url-handling-on-windows ?

[deepak1556]

Thanks @bpasero , the issue only affects non standard custom schemes and data urls. The ones we use vscode-file, vscode-webview for loadURL are standard schemes, will continue to work as expected.

[alerque]

Any comments on an expected time frame for this to be released? Not to pester, I'm just evaluating how to respond to the backport requests to apply this as a patch to the existing release version on Arch Linux.

[deepak1556]

Unless we need to revert for major regressions, this change will be available in our 1.98 release in the beginning of March.

[samnn]

Any comments on an expected time frame for this to be released? Not to pester, I'm just evaluating how to respond to the backport requests to apply this as a patch to the existing release version on Arch Linux.

With the icu update it is now relatively difficult to fix paste for code. Downgrading electron32 requires several dependencies be downgraded, including icu. Downgrading icu breaks the system badly.

Attempting to downgrade code itself to 1.94.2 to fix the issue also runs into an icu dependency issue.

[yannleretaille]

With the icu update it is now relatively difficult to fix paste for code. Downgrading electron32 requires several dependencies be downgraded, including icu. Downgrading icu breaks the system badly.

Attempting to downgrade code itself to 1.94.2 to fix the issue also runs into an icu dependency issue.

@samn For arch users, I recommend installing icu75 from the AUR. You might still need to downgrade flac to 1.4.0 (and potentially packages that depend on it) as well, but that does not cause the aforementioned system breakage.

On my system, I was able to fix this by installing icu75:

# paru/yay -S icu75

and downgrading the following packages:

# sudo downgrade electron32 flac audacity electron27 electron31 electron33 libsndfile

to the following versions:

audacity (1:3.7.1-2 => 1:3.7.1-1)
electron27 (27.3.11-9 => 27.3.11-8)
electron31 (31.7.7-3 => 31.7.7-1)
electron32 (32.3.1-3 => 32.2.8-3)
electron33 (33.4.1-3 => 33.4.0-1)
flac (1.5.0-1 => 1.4.3-2)
libsndfile (1.2.2-3 => 1.2.2-2)

You can check which packages need to be downgraded by just running sudo downgrade electron32 and selecting version 32.2.8-3.