Brian McFee

Results 885 comments of Brian McFee

I've expanded the advanced example notebook for specshow to cover the vscale modes. This notebook is *definitely* too big at this point, but I'll defer breaking it up to a...

I'd like to finalize this PR soon and move on to other display issues. I do think it needs some input from others though - @stefan-balke ? @lostanlen ? The...

One more questionable decision here: what should the default cmap for phase be? I've picked twilight for now, but I wonder if twilight_shifted would be more appropriate? - twilight uses...

Change to `twilight_shifted` is implemented. I also realized that this is more consistent with the divergent map (coolwarm) putting gray/white at the center point.

I've been chewing on this a bit over the past couple of days, and using it internally. Some thoughts: 1. The API feels comfortable to use and does make code...

> * cut the `phase_unwrap` mode > > * rewrite the `phase_unwrap_diff` mode to do phase advance correction. These are now done. I also took the opportunity to simplify and...

With the revised phase unwrap plot, the image comparison test now looks as follows: ![image](https://github.com/user-attachments/assets/f5d8fa51-c835-4c3d-8136-ee215b6babf9) This seems a lot better to me at least.

Final update on this, I think: - `phase_unwrap_diff` is now `dphase` - I've added a `dphase_t` mode for transposed phase differentials. Note that this is not a group delay plot...

I think it's time to stick a fork in this PR. I'm happy with the functionality, and I think the API documentation is about as clear as I know how...

Iterated on this design a bit with our robot friends, and I think it's going to work out pretty nicely. Summary: - Add a parameter `vscale:Optional[Union[str,matplotlib.colors.Normalizer]]` which selects the value...