Brian McFee

Results 885 comments of Brian McFee

> Using subharmonic values in k did end up working! [Here is the new gist](https://gist.github.com/danferns/c271644f7be32ff3b221e016a35fb691). We made a very simple metronome beat that moves from 4/4 to 3/4 then 5/4...

Thanks for this! To my recollection, this inherits from the matlab implementation that I ported back in 2013 or so, but I see no reason to keep it that way...

Digging more into the PR mentioned above, here's the initial comment: https://github.com/librosa/librosa/issues/1700#issuecomment-1891263608 I'm now thinking the iterated rounding is probably where the original cause of #1700 comes from (though I...

Had a vibe-coding debug session and I think we're in business now with a non-iterative implementation: ```python def phase_vocoder( D: np.ndarray, *, rate: float, hop_length: Optional[Union[int, Deprecated]] = None, n_fft:...

Ah, the updates to the yin code are purely @dsuedholt , not me. But I'm glad his work is being appreciated!