Brian McFee

Results 885 comments of Brian McFee

Coming back to this after working out some instrumentation. The following code is very helpful for getting a detailed log of where import is spending its time: ``` export EAGER_IMPORT=1...

> It's wasn't in the import I provided two lines of reproduce in the issue. Back then the imports probably didn't had warmup and now they have somewhere. I'm not...

> 'll take a stab at refactoring this to see if it can help bring this down. I don't see any obvious reason why it would, but this module is...

Following up on this a bit: - There are a few functions that could make more sense to add in mir_eval than in librosa, eg pertaining to annotation processing (visualization,...

> Thank you for opening this issue. I am happy to support this activity by occasionally porting some functions from the list. However, I may need some guidance on what...

> motion to also credit Risset for this glissando Yes of course - it's attributed properly in FMP, I'm just being sloppy in my list above 😅

Follow-up: I prototyped the warping path to grid function yesterday, and the following seems to do exactly the job: ```python y_fast, sr = librosa.load('/home/bmcfee/git/librosa/docs/examples/audio/sir_duke_fast.ogg') y_slow, sr = librosa.load('/home/bmcfee/git/librosa/docs/examples/audio/sir_duke_slow.ogg') Df =...

> [@ISSOtm](https://github.com/ISSOtm) That approach would mean some uses of audioread would work in python 3.13, but others would error. Whilst it's tempting (and would certainly solve my personal use of...

> As a user of the library, I'm in favour of install time errors I find them much easier to identify and debug than runtime errors. I'm with you on...

Quick follow-up to this thread, I've implemented in #148 the alternative solution described above: a soft-failure (warning) without lazy-loading, and a `pip install audioread[legacy]` mode to force the external packages...