Brian McFee
Brian McFee
Following up with a fleshed out prototype. Here's a comparison of *I Got Rhythm*, 30-60 seconds, out of the JAAH collection. First, using the current implementation (matplotlib defaults, mir_eval.segment display):...
Eh I more or less identify as chordy at this point 😆 > * Adding some kind of pattern overlay (e.g. [hatches](https://matplotlib.org/stable/gallery/shapes_and_collections/hatch_style_reference.html)) to designate chord subtypes. I think within a...
Right, the hatches aren't implemented yet - that was just an unrelated aside to document my thinking on the choice of defaults and utility of root+third viz.
Here's an update of the above, 30 seconds now instead of 15, and showing the hatch patterns for 7ths:  and here's another track (Night in Tunisia), 0-60sec, to show...
Yeah, I mean if we stick to 7ths, it has a nice [fruit stripe](https://en.wikipedia.org/wiki/Fruit_Stripe) vibe. The patterns look pretty bad if used as an overlay on a spectrogram:  but...
Thanks @lostanlen ! I completely agree that there's a limit to what we can achieve with a static display like this. My aim here is primarily to strike a good...
Quick follow up, i was reminded of a bug i ran into while doing the recent matplotlib modernization that broke clipping of text box annotations on segment displays. I'll try...
Looking into the clipping path stuff today - for the record, the original issue I encountered is documented here https://github.com/matplotlib/matplotlib/issues/28717 , and this is confirmed to be fixed by subsequent...
I expect the label clipping issue is not going to be resolved any time soon, so I'll just move ahead with this PR as is. (When mpl fixes it, we...
I have not yet written tests for this - I want to get linting and other checks through first.