Brian McFee

Results 136 issues of Brian McFee

:wave: @dofuuz are you at all interested in providing a conda-forge package for this library? libsoxr itself is already available https://anaconda.org/conda-forge/soxr so there shouldn't be any significant barrier here. The...

[review issue](https://github.com/openjournals/joss-reviews/issues/2167) I read through the paper, and have a few comments for improving it. ## Related work A few projects that aren't, but should be cited: - Mauch, Matthias,...

[review issue](https://github.com/openjournals/joss-reviews/issues/2167) There are guidelines for contributors in the readme (great!), but there need to also be guidelines for users seeking to report bugs and get help.

[reference review issue](https://github.com/openjournals/joss-reviews/issues/2167) In hitting the "automated tests" section, I noticed a couple of things about the unit test framework that could be improved. 1. All tests seem to detect...

:wave: JOSS reviewer here, following on the main review issue https://github.com/openjournals/joss-reviews/issues/2167 In working through the documentation, I was confused by the `change_tone` function. I gather that this is a pitch...

At the risk of opening a horrible can of worms, I'm opening this discussion to get thoughts, opinions, and feedback on the possibility of extending librosa to support just intonation...

discussion

**Is your feature request related to a problem? Please describe.** This was alluded to in #1426 , but it would be handy to finally provide an implementation of the tempogram...

functionality

**Is your feature request related to a problem? Please describe.** Our tempo axes represent data on a BPM axis, which is great if you want to understand the (local) speed...

enhancement
display

**Is your feature request related to a problem? Please describe.** #1326 introduced an accelerated display for waveforms that switches between downsampled envelope plots and sample-precise step plots depending on the...

enhancement
functionality
display

**Is your feature request related to a problem? Please describe.** Documenting this conversation with @achabotl - The `AdaptiveWaveplot` class is used by `waveshow` to dynamically switch between a `step` plot...

enhancement
display