Bjorn Lu

Results 767 comments of Bjorn Lu

Why can't the action checkout the PR branch using a flow/logic like this? https://github.com/actions/checkout/issues/331

I still don't quite understand the limitation. The issue_comment event has a way to get the PR number, pkg.pr.new should be able to grab the information / latest sha and...

Sounds good to me. Feel free (or anyone else) to send a PR to add the templates. I'd lean on trying to make the templates as similar to the others...

It only works for the server-side. Is there a reason you want to apply them in the client too? For those logs you mentioned specifically, those are logged with `console.debug`...

The React API has the assumption that `` is the root HTML that renders `` and everything else. The templates setup here is different where `index.html` dictates that instead, the...

Are you seeing the flash in dev or build? In build it shouldn't be flashing as the CSS are in the head. In dev, it's kinda expected at the moment...

Going to close this for now to clean up the issues list, but feel free to follow-up with any questions if you have.

Is there anything else we need to do for this issue? Seems like based on the PR links above, the graph had shrunk down a lot. About `js-yaml`, I don't...

I haven't tested, but following the repro, setting `manualChunks` to create a specific chunk for `framework.js` should fix it. However, it's not always easy to spot which files to chunk...