Bjorn Lu

Results 767 comments of Bjorn Lu

Closing as can't be reproduced.

Perhaps we could patch `connect` so that it handles `.catch()`? IIUC [here](https://github.com/senchalabs/connect/blob/0a71c6b139b4c0b7d34c0f3fca32490595ecfd60/index.js#L235) and [here](https://github.com/senchalabs/connect/blob/0a71c6b139b4c0b7d34c0f3fca32490595ecfd60/index.js#L239) could have a trailing `.catch(err => {})` which would call `next(err)`, and it should properly work...

Yeah this may be hard to fix because the no-importers check is used to assume a module is a root, e.g. if you `ssrLoadModule` a `.js` file, that file would...

Yeah I think it makes sense to enforce `.md`, but it won't resolve every links. Some links we're using root paths too, like `[why](/guide/why)`, and that won't work when editing...

It should be fixed along with https://github.com/vitejs/vite/issues/20294. v6.vite.dev is the same as vite.dev at the moment.

The SSR setup is a normal NodeJS server (using express) that you can start up with `node server.js` after you've run `vite build` to build the files. Perhaps https://vercel.com/guides/using-express-with-vercel helps?...

I guess it's not hard to add a `,color = false` option to disable colors, feel free to send a PR for that if you'd like. But at the same...

It does currently only reports on the `package.json`, but I'd like to expand it towards more files as well, particularly on published files (something I'm working on in the next...

Looks like we need to use a more proper parser to fix this. I tried https://github.com/npm/hosted-git-info but the API works awkwardly again where it can't parse from the shorthand, and...

Note to self, there's also https://www.npmjs.com/package/git-url-parse but still kinda beefy