Bjorn Lu
Bjorn Lu
Do we need snapshot testing for all tests? Seems like these are rather short and can be asserted entirely with a single string. The features are also well-defined and isolated...
Looks great! Thanks for updating it
Sounds good to me 👍 I don't think there's particularly cases where it's wrong to add, but probably just unnecessary, e.g. if the package was never intended or not cared...
Could it be set for the config loading specifically only? I'm not sure if Vite should change the default depth as that might expand other logs.
Sorry for not responding before. I was thinking the depth could be more of an option for `createDebugger()` options, and we can set the value on log.inspectOpts.depth so that the...
I'm not quite sure what you mean. Doesn't my code example only applies the custom depth to an instance of `debug()`? So only calling the returned `log()` will have the...
Oh, what I was thinking is that we don't need to have a new `debugDepth` config in Vite. If the user wants to configure that, I think it's enough to...
Directly configure the environment variable. The issue though is that because it defaults to 2 (via nodes formatWithOptions), it's not the best default to use for config logging. We could...
I think since it's only debug information, it should probably be safe. They should also get more logging of the config by default which I think is better.
The function isn't pure which is true, but the PR is tainting that more. Previously: Given the same `process.env` conditions and same `.env` values and the time `loadEnv()` is called,...