Bjorn Lu

Results 767 comments of Bjorn Lu

Thanks for fixing it. I actually did locally but found some other issues that made base not working (and then forgotten to follow up), but anyways it's probably good enough...

This looks like a bug in the compiler, which handles adding the scopes. I'll transfer this issue there. If you'd like to fix this, the scoping logic mostly happen in...

The issue is of snippets being a hidden/special variable in the module script once it's declared in the markup. In Vite's scanner, it takes the content of `` as is...

I've added this to the team board for discussion. I'm unsure if this is _the_ way we want to support externalizing things, because now a build option would affect a...

In a recent meeting, we decided to go with `resolve.external` as _the_ way of configuring things as external in dev and build. The feature is tracked at https://github.com/vitejs/vite/issues/6582. Supporting that...

Hi, sorry for the wait. We don't usually have timelines for features as the project is community supported. However, I might try to take a stab at this for Vite...

I tried to implement `resolve.external` recently, but it became harder than expected. Not only we need to match `rollupOptions.external`, but also `ssr.external`. And there's multiple design questions such as: 1....

Thanks for the offer. I won't speak for the other team members, for me I'm limited on bandwidth currently to implement it even with so. With that said, if we...

Typically in Vite if you want to use very new syntax like this, you need to configure this Vite config: ```js esbuild: { // either this target: 'es2023', // or...

My tests were from installing the astro repo tarball from github, but any large-sized repos should also cause the same issue with the file names. @43081j mentioned that he's working...