Bjorn Lu

Results 767 comments of Bjorn Lu

As noted in https://github.com/vitejs/vite/pull/6583#issuecomment-1024148754, it would be great if you can explain how you encountered the issue and what error it gives. That would help us evaluate the correct fix...

Thanks for the example @hasangenc0. I tried implementing this at https://github.com/bluwy/vite/tree/rollup-options-external. Turns out there's a lot more to be done to fully support externalizing deps. I think I got it...

A workaround mentioned in https://github.com/vitejs/vite/issues/6393#issuecomment-1006819717 might help for now.

Besides the implementation not being done yet, in a recent team meeting we discussed to have the new option at `resolve.external` to support both dev and build. I haven't got...

> @bluwy do you have a good example of this one? I think `import 'external-dep'` may only work if the user defines an import map for it. In that case,...

I think this should be fixed now in Vite 2.9 ([changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md#avoid-splitting-vendor-chunks-by-default)). Would appreciate if y'all can verify this, and whether this can be closed.

I think this issue is already fixed in Prettier v3 and can be closed. Plugins should be specified via: ```json { "plugins": ["prettier-plugin-svelte"] } ``` In the prettier config file....

This is a Vite issue: https://github.com/vitejs/vite/issues/12336

I had experienced this before while working on the REPL locally. It doesn't happen very often, but I think it's because unpkg noticed repeated requests from the same client and...

I think it makes sense to not inline `rel="icon"` by default, and the same for manifest files too