vite icon indicating copy to clipboard operation
vite copied to clipboard

feat: tree-shake preload

Open caoxiemeihao opened this issue 1 year ago • 3 comments

Description

image

Additional context

Reproduction 👉 https://stackblitz.com/edit/vite-pull-11646?file=.gitignore,dist%2Findex.iife.js%3AL8-L46&terminal=dev


What is the purpose of this pull request?

  • [ ] Bug fix
  • [x] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Read the Pull Request Guidelines and follow the PR Title Convention.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

caoxiemeihao avatar Jan 10 '23 03:01 caoxiemeihao

I'll convert to draft as the tests are failing.

sapphi-red avatar Jan 16 '23 08:01 sapphi-red

How do I get the CI to run again? My local tests are working fine!

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 616.51 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.21.2 - ~/.nvm/versions/node/v14.21.2/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 6.14.17 - ~/.nvm/versions/node/v14.21.2/bin/npm
  Browsers:
    Chrome: 109.0.5414.87
    Safari: 15.4
  npmPackages:
    vite: workspace:* => 4.1.0-beta.0 
image

caoxiemeihao avatar Jan 21 '23 09:01 caoxiemeihao

@caoxiemeihao I reran the CI. It failed again. I don't think it's a flaky fail. Perhaps you forgot to run pnpm build before running pnpm test.

sapphi-red avatar Jan 21 '23 15:01 sapphi-red

Cleaning up some stale PRs. Feel free to open a new PR for this once the tests are fixed!

bluwy avatar Sep 19 '23 08:09 bluwy