Amir Blum

Results 95 comments of Amir Blum
trafficstars

This PR touches on 2 things: - parent-child relationship between producer and consumer - storing link to the producer on the consumer. I wonder if they are mutually exclusive. Always...

@McSick Thanks again for working on this. Are you still interested in finalizing it? should we keep the PR open?

> @dyladan @blumamir do you have any remaining concerns on this PR that haven't been addressed? If not I think this is good to go. Thank you @JamieDanielson , sorry...

@peterabbott can you please share the implementation of the hook that you plan to use in your lambda? is it something specific to your setup or is it a generic...

@MrAlias go auto instrumentation is effectively an opentelemetry SDK. It starts and end spans, exports them, manages context, etc. I think that while having another "go native" opentelemetry SDK living...

> > I think that while having another "go native" opentelemetry SDK living alongside the eBPF SDK in the same process is technically feasible > > @blumamir the eBPF instrumentation...

And I get another exception when pressing "About": ``` TypeError: Cannot read property 'length' of null ProxyComponent.render src/components/settings/DetectedSettings/DetectedSettings.js:23 20 | const ctx = window.halinContext; 21 | 22 | let roles...

Implemented in https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2289 Would appreciate any review on this PR 🙏

If the data is sanitzed, and we write some text like "SELECT ? FROM ?" in the attribute value, it could be hard for backends to correctly label this value...