Amir Blum

Results 95 comments of Amir Blum
trafficstars

Thanks @tigrannajaryan , I will bring it up in the next SIG. Why use `fixed32`? isn't the flags 8 bit (1 byte) value by definition? Another issue, since proto 3...

Ok, I see there is no `fixed8` type in proto. Still, if the value is expected to be 8 bits at most, It will be more efficient to use [varints](https://developers.google.com/protocol-buffers/docs/encoding#varints)...

> Maybe slightly smaller over the wire (2 bytes instead of 4) but it requires more processing for encode/decode since it requires dropping the msb of each byte and doing...

> > Another issue, since proto 3 has no `optional`, if the user is using an exporter with an old version of the proto, the field will not be sent...

> Whoever is is making this change in the proto need to do the usual interoperability exercise: I'll try to answer according to my understanding: > * How old receivers...

> I see this also as another case supporting the introduction of auxiliary version information to the protocol I support. I think this will be the cleanest way to work...

I need this feature as well in order to reduce the verbosity of noisy instrumentation libraries in a general and dynamic manner. At first, I was planning to add config...

To summarize my biggest concern with the current direction is that, to my understanding, the attached key will only be active for the duration of the top most wrapping `context.with`...

I had the same issue and ended up implementing a sync api for the detectors and implemented a few sync detectors with the api. Code can be found [here](https://github.com/aspecto-io/opentelemetry-ext-js/tree/master/detectors) I...