Amir Blum comments

Results 95 comments of


                                            Amir Blum

trafficstars

Getting error "could not resolve" while doing `npm i opentelemetry-instrumentation-elasticsearch`

Thanks for letting us know. Is it still relevant? Can you please paste here the dependencies parts of your `package.json`?

Sequelize instrumentation is not working.

Thanks for the update :) Looks like it is working for you now, right?

perf(instrumentation-pg): do not split query to determine operation name

This issue is discussed in semantic conventions for database spans [here](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md): > The span name SHOULD be set to a low cardinality value representing the statement executed on the database....

feat: kafkajs instrumentation

Thank you @seemk

feat: kafkajs instrumentation

Another thought, should this new instrumentation be added to "@opentelemetry/auto-instrumentations-node" as part of this PR, or should it be done separately in a followup PR?

fix(instrumentation-mongoose): Fix instrumentation for Mongoose Model methods, save() and remove(), by passing options argument to original method calls

@ferrelucas let me know if you need any help fixing the CI issues. once it is green we can merge and release this fix

fix(instrumentation-mongoose): Fix instrumentation for Mongoose Model methods, save() and remove(), by passing options argument to original method calls

> @blumamir thanks, I have fixed the lint issues. > > I just realized the Unit Test issues are giving the `MongoServerError: Transaction numbers are only allowed on a replica...

fix(instrumentation-mongoose): Fix instrumentation for Mongoose Model methods, save() and remove(), by passing options argument to original method calls

> I believe I don't have permissions to make these changes in the Github Actions > Would it be feasible to do it on your side? If I am not...

wip: fix dual publish express

@JamieDanielson Wondering if this is still relevant and should be kept open.

Support for Mongoose 7

Thanks @carlpett As marc mentioned, we usually prefer to introduce new supported major version as a PR here with `tav` and a human eye to brief the changes and verify...