Amir Blum

Results 95 comments of Amir Blum
trafficstars

I really like this proposal - to propagate the async task down to resource attribute consumers. This is a backward-compatible (I think) and very clean way to address the issue....

Should we also add a comment under [upgrade-guidelines in main README](https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines)?

> @YanivD sorry for the long delay here. We talked this over in the SIG yesterday, and were wondering if you'd like to try adding a configuration option that lets...

The Lint fail in CI seems unrelated to this PR: ``` > [email protected] docs:test /home/runner/work/opentelemetry-js/opentelemetry-js > linkinator docs --silent --retry && linkinator doc/*.md --silent --retry 🏊‍♂️ crawling docs [525] https://img.shields.io/codecov/c/github/open-telemetry/opentelemetry-js?style=for-the-badge...

added lables for all the instrumentation to verify test-all-versions pass with new node version

I think we should also add node 20 [here](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/379b7571fe3fead239285b503581094f42a79d66/.github/workflows/test-all-versions.yml#L21)

Adding here the comment from the PR, that changing the default behaviour for baggage key collection in the future to a "safe one" will probably be a breaking change for...

> > LGTM > > Should we add some note in the README about this package not implementing any semantic convention at the moment? > > I thought the absence...

> 2\. We are considering using OpAMP for managing Otel SDKs, which already have gRPC as dependency (because they implement OTLP), so the argument that gRPC is a complicated dependency...