opentelemetry-js
opentelemetry-js copied to clipboard
Use interface for span in span processor
This prevents compilation errors when differing versions of the sdk-trace-base package are in the node_modules tree
Codecov Report
Merging #2931 (14529e5) into main (ce7e98f) will decrease coverage by
0.61%
. The diff coverage is100.00%
.
:exclamation: Current head 14529e5 differs from pull request most recent head 76925ff. Consider uploading reports for the commit 76925ff to get more accurate results
@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 92.81% 92.19% -0.62%
==========================================
Files 184 69 -115
Lines 6066 1999 -4067
Branches 1296 437 -859
==========================================
- Hits 5630 1843 -3787
+ Misses 436 156 -280
Impacted Files | Coverage Δ | |
---|---|---|
packages/opentelemetry-resources/src/Resource.ts | 100.00% <100.00%> (ø) |
|
...ckages/opentelemetry-sdk-trace-web/karma.worker.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...s/opentelemetry-core/src/platform/node/sdk-info.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...opentelemetry-core/src/platform/node/globalThis.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...pentelemetry-core/src/platform/node/performance.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...emetry-api-metrics/src/platform/node/globalThis.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...lemetry-resources/src/detectors/ProcessDetector.ts | 31.81% <0.00%> (-68.19%) |
:arrow_down: |
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts | 84.48% <0.00%> (-15.52%) |
:arrow_down: |
...lemetry-resources/src/detectors/BrowserDetector.ts | 93.33% <0.00%> (-6.67%) |
:arrow_down: |
...telemetry-sdk-trace-base/src/MultiSpanProcessor.ts | ||
... and 114 more |
I guess such problems are not limited to SpanProcessor
. Any exported class may result in similar problems. see the recent issue for contrib instrumentations.
I guess to fully avoid this it's needed to remove classes from all exports.
I guess such problems are not limited to
SpanProcessor
. Any exported class may result in similar problems. see the recent issue for contrib instrumentations.I guess to fully avoid this it's needed to remove classes from all exports.
It is very possible. We can't remove those exports now unfortunately, but we can remove them from the interfaces we export. I'll create an issue to do a more thorough review.
#2932
Should we also add a comment under upgrade-guidelines in main README?
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
Closing this PR as it has been open for a while without activity.