Ran Benita

Results 431 comments of Ran Benita

> @bluetech not really, I meant to apply those later (I only created a Draft PR to not lose the local commits I made). Ah sorry for the assumption. The...

@symonk I updated the PR description to add `Fixes #6881`.

> We already have the run parameter to xfail, or do you mean something else? The `xfail` that is added for the empty parameterset is indeed `pytest.mark.xfail(run=False)`, however `--runxfail` overrides...

I think @RonnyPfannschmidt refers to the nasty hack in skipping.py: https://github.com/pytest-dev/pytest/blob/d69e9e60d6c2ce530cac7b372165b42f33153df0/src/_pytest/skipping.py#L49-L61 However this hack is not relevant for the xfail mark `pytest.mark.xfail` that the empty paramterset is using, because the...

I don't think pytest is going to ship a mypy plugin. It's quite finicky and besides, there are other type checkers nowadays. The problem you are describing is a more...

@pbrezina Yes it is my intention to make `register_function` public in some way. Also see discussion in #11662. There are still some design issues we need to work on, like...

@nicoddemus The implementation itself does need to get at the FixtureManager. So it needs to take `config: Config`, or alternatively fetch it from a `Node`.

Ah missed the type. The minor problem here is one I hinted at above, namely that there a case where `node=None` (`fixturedef.has_location == False`), which is subtly different from registering...

Just to throw another use case - the [py_webauthn](https://github.com/duo-labs/py_webauthn) library is currently using pyOpenSSL to verify WebAuthn attestation certificates. I think it could drop the pyOpenSSL dependency and rely solely...

Hmm, thanks for the issue. I figure we should plumb the pytest verbosity options into `maxDiff`.