Ran Benita

Results 431 comments of Ran Benita

I think checking for a function would be ideal, but it doesn't seem possible to do cleanly, without hacks like reverse-mapping filename+lineno to a function and such.

Hi @warsaw, Is it possible for you to solve this issue more generally? In one of my projects which handles sensitive data, I wrap all sensitive values in a `Secret`...

Sounds reasonable to me. Normally this doesn't matter because entrypoint plugins are loaded already by the time `PYTEST_PLUGINS` is considered, but it does matter when `PYTEST_DISABLE_PLUGIN_AUTOLOAD` is used. And then...

Yes, this is a TODO in #7469. I think we can do it. We'd need to audit the API for exposure, specifically, make the constructor private (using the `is_pytest` trick...

Hopefully I can review this some time this week. But I did try this PR out and it seems to work as expected (well, except that the progress stuck around...

I think we can implement this in a cleaner way, as an internal plugin. This will avoid complicating TerminalReporter, and also allow to disable the feature if absolutely necessary by...

Replaced by #13728, thanks @annatasio.

Thanks for reporting the changelog errors, will be fixed by #470.

> And then not throw the PluginValidationError exception because my hookimpl.function is a type . Since we Cythonize our plugin, and the source version works just as expected. Just to...

Seems like there is an issue in Cython about it: https://github.com/cython/cython/issues/4888 I think adding some Cython-specific workaround would be fine, but I'm hesitant to drop the check entirely due to...