Ran Benita

Results 431 comments of Ran Benita

So the problem in this issue is that the test doesn't tear down the resources it sets up. So I will close this issue again. However, I found the reason...

This is fixed in Tornado 6.4.1: https://www.tornadoweb.org/en/stable/releases/v6.4.1.html

I'm closing this as per the (retro-added) breaking change note here: https://docs.pytest.org/en/stable/changelog.html#breaking-changes

@FamousPond the merge commit you pushed seemed to have removed most of your code changes, at least according to the PR's "Files changed". My recommendation is to use `git rebase`...

@woutdenolf Did you try https://docs.pytest.org/en/stable/reference/reference.html#confval-consider_namespace_packages?

@youknowone > Will the return type be (ast, Vec) in that case? I think that makes sense, yes. The lalrpop doc seems to suggest this. I also saw that the...

I don't have much to add except to say that having this will be truly great, my code is littered with "aware"/"not aware" comments which really should be in the...

@millerdev Since the issue is closed, could you explain your use case for this change? I'm asking because we generally prefer to put functionality in plugins, so we'd like to...

Seems there is a use case for moving this functionality to core, but that means it can't be a plugin. We prefer functionality to be in plugins because it keeps...

@virendrapatil24 The proposed solution of catching the exception in `__exit__` has the disadvantage that the `fail` is raised from the `__exit__` (and is thus chained to the exception under test),...