Ran Benita

Results 431 comments of Ran Benita

One note, `pytest.yield_fixture` is deprecated, you should change it to `pytest.fixture`. Also, you should just remove the `yield`, it's not really needed (you don't need a hook wrapper, just a...

Argh sorry I didn't mean hook/hookwrapper, I meant fixture/yield fixture. You should write it like this: ```py @pytest.fixture(scope="session", autouse=True) def django_db_setup(django_db_setup, django_db_blocker): with django_db_blocker.unblock(): # Code that requires DB access...

Yes, it's probably fine, just something to try. The important thing is to make sure to request `django_db_setup` from your own `django_db_setup`.

I had the same thought: https://github.com/charliermarsh/ruff-lsp/pull/76#issuecomment-1454257946 It does feel much cleaner, however these are not regular fixes (+ it makes every lint "fixable"...) so should be distinguished in some way...

I was thinking, since this is not useful for regular cli usage, but only for LSP-like scenarios, that the LSP should just tell Ruff "please generate these", in one way...

Now that we explicitly reexport pcsc-sys, this sounds fine to me. Will accept a PR for this.

I've picked some of the changes to master in #188. You can find the remaining changes rebased on master here: https://github.com/bluetech/execnet/commits/ronny-changes-2

@zmedico Thanks for following up! It seems to me better to merge https://github.com/pytest-dev/pytest-xdist/pull/1072 and not this. It seems intentional that execnet doesn't request rinfo always, allowing the user to choose...

@zmedico I admit I'm a bit confused what the test is testing. What is the failure it is testing against?

Hi @DWesl, Am I correct that this is a bug report by way of pytest-forked, which uses `py.process`? I'm asking because, given that the `py` library is deprecated, a better...