Błażej Sowa

Results 57 comments of Błażej Sowa

Nvidia added support for AMDGPU Reverse PRIME with the 470.42.01 version of the driver. I recommend updating it and trying again as it worked in my case.

@kscottz @mjcarroll @130s Could you please move this through? It would really help me if the package was released to Noetic rosdistro.

What's the status of this PR? @jonbinney Could you please merge this? I'm interested in using the polygon filter but I'd rather avoid copying the whole implementation to my project.

I tested the `polygon_filter` and it seems to work after implementing the fixes from my review. However, I found a general flaw in how some of the filters are implemented....

> As for your comments about the lifecycle node. I tried to stay close to the implementation of the other filters, e.g. box filter and indeed noticed that for example...

Hi, I can help you commit your work throught git if you want. I'm interested in those changes

> The event mode requires the poll timer callback to be non-blocking and return immediately (real-time behavior). > The poll timer callback is executed in the CANopen event loop and...

> Does this fail if we don't execute in task? Or why do you need to know if it is run in a seperate thread? AsyncWrite and Wait should be...

I believe I am facing i similar issue. My theory is that in the `event` mode, SDO requests (using `universal_set_value` and `universal_get_value` methods) called from `poll_timer_callback` do not work. In...