Sebastian Beltran comments

Results 422 comments of


                                            Sebastian Beltran

Use ESLint on JavaScript

I think you could make it so that only JavaScript files have semicolons, and markdown files don’t have semicolons.

update homepage link http to https

Should I update the branch?

Should 1.0.0 be `latest` on npm?

Now the latest version is 1.1 ![Image](https://github.com/user-attachments/assets/633a8bd7-6dcb-47c5-98b2-5542b32f6f7c)

feat: create `router.error` method to allow explicit definition of error-handling middleware

yes, see https://github.com/pillarjs/router/issues/162

test: skip query test on node <22

Could you do something like this in Express, please, so we don't have to repeat the same logic multiple times? https://github.com/jonchurch/express/blob/bd302bf4606259a7703a06a2c5d269eed1679eb1/test/support/utils.js#L78

test: skip query test on node <22

Now we just have to wait for a maintainer (TC) to approve the CI run, and then I’ll be able to give the green light.

test: skip query test on node <22

Something curious is that the error no longer appears, new PRs were opened and didn’t trigger any error in the CI

Add a helpful error message when pathRegexp fails

Look https://github.com/pillarjs/path-to-regexp/pull/363, I think it's better to do this in path-to-regexp than in the router

refactor!: replace `is-promise` dependency with `instanceof` check

I like the idea of showing that warning

`engines.node` suggests support for Node.js `>= 0.8`, but #80 broke with Node.js v14 and earlier

cc: @pillarjs/express-tc