Sebastian Beltran

Results 422 comments of Sebastian Beltran

We make comments and a short summary, maybe I can arrange for the session to be recorded.

I don't think there's a problem with changing `var` to `const` or `let`, as, for example, `multer` and version 4 of `express` used them while still supporting very old versions...

This would be great, but unfortunately Node.js still doesn't support it, and it might take a long time before someone manages to implement it in the core (https://github.com/nodejs/node/issues/48412).

I don't know if we should wait until the API is stable since it will be released as experimental.

We have a linter, which is Standard, and it also applies certain formatting. The previous maintainer implemented it in most, if not all, repositories. We want to standardize a new...

Please take a look at the migration guide. I know some features aren't available the same way they were in version 4, but for the vast majority of cases, the...

[secure-json-parse](https://github.com/fastify/secure-json-parse) also has protection against constructor poisoning. Should I include that as well? Are there any use cases for it?

Yeah, although I don't think it hurts to add an option for constructor poisoning, so I'm going to add tests for the constructor prototype and add the option

> I'd consider dropping __proto__, constructor.prototype (and possibly even constructor outright) from user inputs silently in a major, and not providing an option for people to toggle it off. If...

I think it should be the other way around—this should be merged first before #6404, since it needs to be deprecated in v5 first for the effect to result in...