finalhandler icon indicating copy to clipboard operation
finalhandler copied to clipboard

`engines.node` suggests support for Node.js `>= 0.8`, but #80 broke with Node.js v14 and earlier

Open trentm opened this issue 10 months ago • 1 comments

[email protected] broke usage with Node.js v14 and earlier: #80 uses String.prototype.replaceAll, but this isn't supported in Node.js v14 (https://node.green/#ES2021-features--String-prototype-replaceAll).

The engines.node in package.json suggests that Node.js >=0.8 is supported: https://github.com/pillarjs/finalhandler/blob/v2.1.0/package.json#L33-L35

Of course, ci.yml only tests with Node.js v18 and later.

For my usage, I'm totally if finalhandler v2 only supports Node.js v18 and later. If so, it would be helpful to update engines.node in package.json, or just remove it.

Thanks.

trentm avatar Mar 10 '25 21:03 trentm

cc: @pillarjs/express-tc

bjohansebas avatar Apr 05 '25 02:04 bjohansebas