Sebastian Beltran
Sebastian Beltran
Currently, several tests are failing on Windows
@ShubhamOulkar Please, open a PR
I can take a look later, I’m also a maintainer of that package.
@targos how can i know if the change i'm making will actually work here? Should I open a PR changing the SHA so you can run CITGM and check if...
This should be fixed with the latest version of the express-server-static types.
If the body is not sent in the response, it will be undefined. That is one of the breaking changes that were made. Check the [migration guide](https://expressjs.com/en/guide/migrating-5).
I don't fully understand your change. How does that fix the original problem? Are we going to release a new major version?
I'm okay with adding that step in the CI, but is the engine change going to be merged? That's what I don't understand.
Sure, I hadn't noticed that this Milestone for v2 already existed. Happy to review it when I have access to my computer.
It's great that you want to help. I'm going to respond to some of your points. > I assume no new features will be merged to v1 I would say...