Ben Smith
Ben Smith
ah, I know what this is. I mmap the sav file and use `ftruncate` to make it 32k. This seems to work on Linux, but it looks like it fails...
@Screwtapello thanks for the explanation! I wonder if there's a short way to get the behavior I want -- create or open a file of a fixed size on both...
Thanks! I don't have a mac to test on so it's a bit tough for me. At least on my linux laptop it looks reasonable: ``` openat(AT_FDCWD, "rom.gb", O_RDONLY) =...
This would be nice to fix, but in the meantime I added a simple workaround. You can run `make rom.sav` to copy from an empty save file.
It might be that vsync isn't working -- that's the only thing keeping it from running as fast as it can.
Hm, yeah that sounds like a tricky thing to work around for a size-sensitive demo like this...
Wow, thanks for doing this! I just skimmed the code, but in general this looks good. @jgravelle-google can you do a more thorough review?
Thanks, looks pretty good! I'm not sure this needs to be upstream (see for example, https://www.npmjs.com/package/wabt and https://github.com/AssemblyScript/wabt.js). One downside is that it will increase the size of the source...
I agree with @sbc100, I think it'll be nicer to have the materials required for packaging kept in a separate repo. This gives us a lot of flexibility too --...
This is one of the motivating use cases for the [annotations proposal](https://github.com/WebAssembly/annotations/blob/master/proposals/annotations/Overview.md#examples). In particular, [this gist](https://gist.github.com/binji/d1cfff7faaebb2aa4f8b1c995234e5a0) goes into some detail about how this could be supported.