Ben Smith

Results 372 comments of Ben Smith

@kripken Good point. Here's another slightly less opinionated option -- we change the various defines (`MEMCHECK`, `FUNC_PROLOGUE`) to check whether they're already defined. In practice this is not much different,...

Fair point. My main concern is that there are existing `.wast` files that we may want to continue to support, especially those that have been copied from the spec testsuite...

@jakobkummerow PTAL! Here is some initial work to start parsing GC types.

IIRC there were some hacks in the old interpreter to try to keep more values in local variables while running the interpreter loop. The new interpreter is refactored to have...

It looks like the web version just needs to be updated. I rebuilt it locally and your example worked for me!

https://github.com/WebAssembly/wabt/pull/1907

I noticed that too, I think there may be a few places where the exceptions flag isn't properly checked.

The main issue is the SIGSEGV; the python traceback happens because of a python2/python3 issue (which has since been resolved, since we've switched to python3 everywhere.) I'm guessing the segfault...

The biggest issue with concatenating wasm modules is that there can be at most one table and one memory, so the concatenated module would have to share them. This is...

Yeah, the `Makefile` is weird and mostly only convenient for me to hack multiple configurations on wabt. It probably should just be removed or made less prominent.