billw2012

More pre/post condition asserts

1

I had to add a lot of my own asserts to the various Id and entity add/remove functions before I finally determined I was killing entities multiple times before calling...

Breaks main menu options added by other mods

2

Specifically in my case the ones added by Enhanced Battle Test. It adds a couple of main menu options for different battle tests, but these disappear when using the Community...

Search doesn't work at all.

8

I just get 404 page regardless of what I search for on the demo pages and my own. My pages: https://sparker95.github.io/Vindicta/

flyPad hard to use in VR

6

### Aircraft Version Stable ### Build info ```json { "built": "2021-09-18T00:34:38+00:00", "ref": "v0.7.0", "sha": "e8ea73b3648d48437ca5df55e280a945fd11dab6", "actor": "Benjozork", "event_name": "manual" } ``` ### Describe the bug Along with #3493, I think...

Dead lock with bad locking.

1

SendPacket can cause RemoveConnectionReference and AddConnectionReference can call SendPacket. The first takes sendLocker then globalDictAndDelegateLocker, the second takes them in reverse. ```` NetworkCommsDotNetComplete.dll!NetworkCommsDotNet.Connections.Connection.SendPacket(NetworkCommsDotNet.IPacket packet, out long packetSequenceNumber) Line 527 NetworkCommsDotNetComplete.dll!NetworkCommsDotNet.Connections.Connection.SendReceiveObject(string...

changenote contents does not have double quotes escaped in the vdf file

1

This causes a failure like below. Its not a big deal for hand written changelog (like mine), but for automated ones it will be a pain. ``` info...ClientJobRemoteStorageSync.cpp (2193) :...

Sort DllExport declarations.

1

If there are any! See here: https://forums.civfanatics.com/threads/avoid-creating-bugs-from-the-exe-calling-the-dll.639167/ Also sort all class interfaces so DllExport interface is in one section, separate from other functions. This will make it clear again which...

Review building sound effects

1

Particularly building sound effects as they will overlap cumulatively. https://forums.civfanatics.com/threads/quick-question.650870/

CvUnit::validateCargoUnits() remove debugging code?

2

This looks like code for debugging some problem, not something we should keep in the code base. Recalc modifiers should fix any problems with changes here, in fact it looks...

Find method for per frame updates

1

d3d9.dll wrapper time? Currently game update is called ever 250ms or so, which makes paging choppy and UI interactions that rely on it unresponsive.