Thomas Beutlich
Thomas Beutlich
> since the library works just fine Well, but not out of the box. See https://github.com/modelica/ModelicaStandardLibrary/blob/maint/4.1.x/Modelica/Resources/BuildProjects/readme.txt#L28-L30. As we also provide the binaries (as part of the released MSL) we need...
> Could you elaborate why that seems wrong to you? The issue I see is that we (MAP-Lib) ship (production) binaries for MSL that are created with a fle Modelicautilities.h...
> * ModelicaTest.Media.TestAllProperties.MoistAir I run git bisect on that test model and it reported > cc408ce564d2af08d76a416b434a63bcae61e79e is the first bad commit The error is only for signal err_h_is now being...
> * ModelicaTest.Media.TestOnly.R134a_setState_pTX I run git bisect on that test model and it reported > f1574e8116fd5e4d72c5cbae4176f29e1dc3445f is the first bad commit #3704 is an actual bug fix that I already...
Confirmed, `ModelicaTest.Media.TestAllProperties.MoistAir` is not yet updated in the v4.1.0 branch of the ref result, see https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0/ModelicaTest/Media/TestAllProperties/MoistAir with https://github.com/modelica/MAP-LIB_ReferenceResults/commit/af2c8f2fe0720044d593d560db635321300afe1b being the latest change as of today.
@casella Please make sure that Politecnico di Milano signs the MA CLA, which is a necessary prerequisite for a merge (according to our project rules). Since time is running and...
> The general idea is good, but: > > * Would like some feedback on the enum. I am not sure if ModelicaFileType is meant to be public. For testability...
> Looking at that model, I think it would be better if the test functions were all different models. Because that gives you a better overview of what parts of...
@sjoelund Can you please sum up what is left to do here?
Oh dear, that is a huge number. 🔢