Thomas Beutlich
Thomas Beutlich
Am 2025-03-12 10:39, schrieb Hans Olsson: > HansOlsson left a comment (modelica/ModelicaStandardLibrary#4300) > > To be clear: I assume 4.0.0 mean the tag v4.0.0, not maint/4.0.x, > right? Yes, v4.0.0...
> So, I think it needs updating a bit. Thanks. PR is updated accordingly.
Well, three approvals and green CI checks ...
> @maltelenz, please back-port to maint/4.1.x Done by #4520.
@GallLeo @MatthiasBSchaefer @tobolar For the sake of consistency it might be useful if the triggered MSL test runs by LTX ReSim could also build the binaries after the MSL sources...
Thanks @maltelenz. It's incorporated, refactored and further tested. The 2 Modelica_*.cmake files are kind of generic. Is the setting of the UNIX CFLAGS alright for you?
Thanks for the two new updates. Will pick them and adapt later. > * compile with `-fPIC` There's a more CMake-like setting: https://stackoverflow.com/a/38297422/8520615
> Actually, the default behavior from cmake already seems good, so looks like we don't need this flag. Yes, I read about it previously, but could not find it anymore.
@maltelenz I pushed your commit and slightly adapted the variable names. Thankfs for the contribution.
CI runs the testsuite now. I'd prefer to have the unit tests close to the sources (and not as part of the .CI folder though).