Thomas Beutlich

Results 394 comments of Thomas Beutlich

This issue is about the gamma unit. And we have already seen in the comments of the corresponding PR #4377 that there's something more fishy than just the unit.

I'd even claim it is too late to mark StateGraph as obsolete for v4.0.0. This would be required to properly discontinue StateGraph for a new major release. By the way,...

> BTW, we need new milestones, at least "Next Minor Version", "Next Major Version". Done: Created new milestones [MSL4.1.0](https://github.com/modelica/ModelicaStandardLibrary/milestone/61) (the next minor version according to semver.org) and [MSL5.0.0](https://github.com/modelica/ModelicaStandardLibrary/milestone/60) (the next...

@Harisankar-Allimangalath Due to #4355 there are merge conflicts now. Can you please resolve them. Thanks.

@Esther-Devakirubai ❗ I resolved the merge conflict and squashed all changes.

> This is not correct; it should also be corrected on master. Addressed by #4374.

> I can open a MR is it seem the right fix Thanks for reporting. Your PR would be appreciated.

> @beutlich I can open a PR but i'm not confident enough in C and Modelica to be able to say that this fix is legitim I see you made...

> please back-port this to maint/v4.1.x Done by #4530.