Add DifferencesTo400.html - MSL 4.1.0 w.r.t. 4.0.0
This is the MSL 4.1.0 library comparison w.r.t. MSL 4.0.0 run in Dymola 2024 by command
ModelManagement.Compare.compareModels(
"Modelica410",
"Modelica Standard Library - Version 4.1.0",
"Modelica400",
"Modelica Standard Library - Version 4.0.0",
"C:/Projects/MSL/Modelica/Resources/Documentation/Version-4.1.0/DifferencesTo400.html",
true);
after renaming the two loaded MSL versions.
There will likely be some later changes, but it is good to have it now. The final version should be also back-ported to maint/4.1.0.
@beutlich I am proceeding with using this information for the Release notes making along with the inputs from https://github.com/modelica/ModelicaStandardLibrary/issues/4260#issuecomment-1925797594
@HansOlsson I am unfortunately no longer able to run the model comparison in Dymola 2024xR1 as it stops execution with the following exception
...
Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer.idealCloser
Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer.transformer
Wrong call of Utilities.Strings.substring:
startIndex = 0 (has to be > 0).
string = ""
Failed to expand ModelicaStrings_substring("", min(1+findFast("", "=", 1, true), ModelicaStrings_length ("")), ModelicaStrings_length("")).
Failed to expand ModelManagement.Compare.Internal.modifierComparison({"Modelica410.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines", "Modelica400.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines"}, "transformer", Dymola_AST_ComponentModifiers("Modelica410.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer", "transformer"), Dymola_AST_ComponentModifiers("Modelica400.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer", "transformer")).
Failed to expand ModelManagement.Compare.Internal.packageModelStep({"Modelica410.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines", "Modelica400.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines"}, {"Modelica Standard Library - Version 4.1.0", "Modelica Standard Library - Version 4.0.0"}, {"Modelica410", "Modelica400"}, {"Modelica410.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer", "Modelica400.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer"}, "model", {" ", " "}, "C:/Projects/MSL/Modelica/Resources/Documentation/Version-4.1.0/DifferencesTo400.html", true, false).
Failed to expand ModelManagement.Compare.compareModels("Modelica410", "Modelica Standard Library - Version 4.1.0", "Modelica400", "Modelica Standard Library - Version 4.0.0", "C:/Projects/MSL/Modelica/Resources/Documentation/Version-4.1.0/DifferencesTo400.html", true, false).
To be clear: I assume 4.0.0 mean the tag v4.0.0, not maint/4.0.x, right?
Am 2025-03-12 10:39, schrieb Hans Olsson:
HansOlsson left a comment (modelica/ModelicaStandardLibrary#4300)
To be clear: I assume 4.0.0 mean the tag v4.0.0, not maint/4.0.x, right?
Yes, v4.0.0 as distributed by Dymola 2024xR1.
I reran that command (with tag v4.0.0) and got:
So, I think it needs updating a bit.
So, I think it needs updating a bit.
Thanks. PR is updated accordingly.
[!IMPORTANT]
Review skipped
Review was skipped as selected files did not have any reviewable changes.
💤 Files selected but had no reviewable changes (1)
- Modelica/Resources/Documentation/Version-4.1.0/DifferencesTo400.html
You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Backported to maint/4.1.x by #4633